Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): fix tableView parent #14170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(android): fix tableView parent #14170

wants to merge 1 commit into from

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Jan 8, 2025

Reverting #13826

@m1ga
Copy link
Contributor Author

m1ga commented Jan 8, 2025

More testing tomorrow

@m1ga m1ga mentioned this pull request Jan 8, 2025
Merged
@m1ga m1ga marked this pull request as ready for review January 8, 2025 21:39
@m1ga m1ga marked this pull request as draft January 8, 2025 21:39
prashantsaini1
prashantsaini1 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@prashantsaini1 prashantsaini1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting the change is correct as people who reported issues earlier were actually using TableView differently than it should be. We should stick to use existing methods to update content as it is the correct way to update proxies internally.

@m1ga m1ga marked this pull request as ready for review January 9, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashantsaini1 prashantsaini1 prashantsaini1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m1ga @prashantsaini1